Add preferential optimization picture#327
Conversation
Alnusjaponica
left a comment
There was a problem hiding this comment.
Thanks for your contribution. I made some minor comments. PTAL.
|
|
||
| # 2. Generate image | ||
| image_path = os.path.join(tmpdir, f"sample-{trial.number}.png") | ||
| image = Image.open("sample.png") |
There was a problem hiding this comment.
It would be better to pass down image path from cli option.
| image = Image.open("sample.png") | |
| image = Image.open("sample.png") |
There was a problem hiding this comment.
Plus, it suffice to open the original image only once, before the loop starts.
5ba754c to
70480ec
Compare
Alnusjaponica
left a comment
There was a problem hiding this comment.
Could you fix the database path?
| Then, launch Optuna Dashboard in a separate process using the following command. | ||
|
|
||
| ```bash | ||
| optuna-dashboard sqlite:///example.db --artifact-dir ./artifact |
There was a problem hiding this comment.
Please use the same DB path. ref: optuna/optuna-dashboard#469
| optuna-dashboard sqlite:///example.db --artifact-dir ./artifact | |
| optuna-dashboard sqlite:///db.sqlite3 --artifact-dir ./artifact |
|
These changes have been reflected. |
Alnusjaponica
left a comment
There was a problem hiding this comment.
Thanks! LGTM.
@nzw0301 Could you take another look?
nzw0301
left a comment
There was a problem hiding this comment.
Sorry for my late responses. I've left a few more comments. In addition, can you explain where sample.png comes from?
|
Thank you for the review. I've made the changes. |
nzw0301
left a comment
There was a problem hiding this comment.
Lovely. Thank you for your response. I was a bit worried about the licence of the picture, but it sounds fine since it's provided.
Motivation
This pull request introduces a new example for generating and optimizing images using preferential optimization with Optuna. It includes documentation, a generator script, and a shell script to launch the dashboard. Below are the key changes grouped by theme:
Description of the changes
add preferential optimization Image
add README