Skip to content

Run the skorch example in the CI#309

Merged
y0z merged 1 commit intooptuna:mainfrom
not522:skorch-ci
Mar 24, 2025
Merged

Run the skorch example in the CI#309
y0z merged 1 commit intooptuna:mainfrom
not522:skorch-ci

Conversation

@not522
Copy link
Copy Markdown
Member

@not522 not522 commented Mar 19, 2025

Motivation

The skorch example is missed from the CI.

Description of the changes

This PR makes it to run in the CI and adds pandas to the requirements.

@not522 not522 added the CI Continuous integration. label Mar 19, 2025
@c-bata
Copy link
Copy Markdown
Member

c-bata commented Mar 21, 2025

@kAIto47802 @y0z Could you review this PR?

Copy link
Copy Markdown
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0z y0z merged commit 70be131 into optuna:main Mar 24, 2025
6 checks passed
@y0z y0z unassigned y0z and kAIto47802 Mar 24, 2025
@c-bata c-bata added this to the v4.3.0 milestone Mar 24, 2025
@not522 not522 deleted the skorch-ci branch March 24, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants