Add version constraint for tensorflow-related ci#304
Merged
c-bata merged 2 commits intooptuna:mainfrom Mar 18, 2025
Merged
Conversation
Member
Author
|
@nabenabe0928 Could you review this PR? |
c-bata
reviewed
Mar 18, 2025
keras/requirements.txt
Outdated
| numpy<2.0.0 # TODO(nabe): Remove this constraint once this issue is resolved. https://github.com/numpy/numpy/issues/26710 | ||
| optuna | ||
| tensorflow-cpu | ||
| tensorflow-cpu<2.19.0 |
Member
There was a problem hiding this comment.
Could you add a todo comment to remove the upper version constraint, and open an issue to resolve this?
Member
|
Let me change the review since this PR should be prioritized to fix scheduled CI. |
Member
Author
|
I've opened the issue #306 to track this CI issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Description of the changes
This PR temporarily fixes tensorflow, keras and tfkeras CI by adding a version constraint to tensorflow.