Merged
Conversation
Member
|
@not522 Could you review this PR? |
Member
|
@ParagEkbote Please apply the black formatter to pass CI (see CONTRIBUTINBG.md). |
Contributor
Author
|
Hmm, I ran pre-commit for CI, and it gets passed for skorch_simple.py, but why is it failing now? |
Member
|
The pre-commit setting has not been added to optuna-examples yet, so could you please check the message in the CI? Sorry for the inconvenience. |
Contributor
Author
|
All the tests are passing. Could you please review the changes? cc: @not522 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the code to ensure that it runs correctly without making any breaking changes. Please let me know if any improvements are needed and I will make the necessary changes.
cc: @not522