Fix TPESampler with multivariate and constant_liar#6505
Merged
c-bata merged 1 commit intooptuna:masterfrom Mar 11, 2026
Merged
Conversation
Member
|
@y0z Could you review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Combining
TPESampler'smultivariateandconstant_liarcan sometimes cause theconstant_liarto function improperly during batch optimization.#6189 fixed the bug that reappeared in #6265, so this PR addresses that issue.
Description of the changes
Revert #6265.
Speed Benchmark
This PR increases storage access and degrades speed. Ideally, this access could be avoided, but making changes to the
Studyclass would be required, which I haven't done in this PR.