fix: correct inverted warning message in pareto front plot#6498
Merged
c-bata merged 2 commits intooptuna:masterfrom Mar 10, 2026
Merged
fix: correct inverted warning message in pareto front plot#6498c-bata merged 2 commits intooptuna:masterfrom
c-bata merged 2 commits intooptuna:masterfrom
Conversation
3dc39fd to
9c42b20
Compare
c-bata
requested changes
Mar 9, 2026
c-bata
approved these changes
Mar 10, 2026
Member
c-bata
left a comment
There was a problem hiding this comment.
LGTM. Thank you for your contribution!
Contributor
Author
Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The warning message in
_get_pareto_front_infohad the constraint and no-constraint strings swapped.What was wrong
When all trials are infeasible (constraints enabled), the warning said "completed" instead of "completed and feasible". When there are no constraints and no trials at all, it said "completed and feasible" when it should just say "completed".
Fix
Swapped the ternary condition on line 230 of
optuna/visualization/_pareto_front.py.