Use f-strings in optuna/storages/journal/_storage.py#6440
Merged
not522 merged 3 commits intooptuna:masterfrom Feb 13, 2026
Merged
Use f-strings in optuna/storages/journal/_storage.py#6440not522 merged 3 commits intooptuna:masterfrom
optuna/storages/journal/_storage.py#6440not522 merged 3 commits intooptuna:masterfrom
Conversation
Addresses optuna#6305 Converted direct .format() calls to f-strings. Left UNUPDATABLE_MSG template-based formatting intact as it's intentionally using a shared constant.
optuna/storages/journal/_storage.py
not522
approved these changes
Feb 13, 2026
Member
not522
left a comment
There was a problem hiding this comment.
LGTM!
To minimize differences, I've removed !r.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #6305
Converted direct
.format()calls to f-strings inoptuna/storages/journal/_storage.py.Note: Left
UNUPDATABLE_MSG.format()calls intact as they intentionally use a shared constant template.Changes
.format()usages to f-strings{var_name=}syntax where appropriate!rfor proper string quoting in user-facing messagesChecklist