Move test_before_trial and test_after_trial_* to test_trial.py and test_study.py, respectively#6429
Merged
c-bata merged 1 commit intooptuna:masterfrom Feb 10, 2026
Conversation
c-bata
approved these changes
Feb 10, 2026
Member
c-bata
left a comment
There was a problem hiding this comment.
Thank you for your pull request!
My initial thought was that having test_before_trial and test_after_trial in separate test files felt a bit awkward to me. While I understand this matches the caller's structure, it feels too tied to implementation details.
That said, this is just a minor point. We should not spend much time on it, so let's move forward. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Description of the changes
This PR is a subset of #6424.
For clarity, I'm splitting the PR into two parts. In this PR, I moved the tests as follows.