Fix combination between PartialFixedSampler and TPESampler with group decomposed search space#6428
Merged
kAIto47802 merged 1 commit intooptuna:masterfrom Feb 13, 2026
Merged
Conversation
… decomposed search space
not522
commented
Feb 9, 2026
|
|
||
| x_sampled1 = study1.trials[0].params["x"] | ||
| y_sampled1 = study1.trials[0].params["y"] | ||
| assert x_sampled1 == x_sampled0 |
Member
Author
There was a problem hiding this comment.
I think that this assertion can be removed because it depends on the implementation of RandomSampler.
Member
Author
|
@y0z @kAIto47802 Could you review this PR? |
kAIto47802
approved these changes
Feb 13, 2026
Collaborator
kAIto47802
left a comment
There was a problem hiding this comment.
Thank you for the PR. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #6427.
Since
TPESamplercontains aGroupDecomposedSearchSpace, it attempts to suggest parameters even for those that were excluded by thePartialFixedSampler.Description of the changes
TPESamplerto respect thesearch_spaceargument.