Fix windows-test failure due to NamedTemporaryFilePool#6417
Merged
c-bata merged 3 commits intooptuna:masterfrom Jan 26, 2026
Merged
Fix windows-test failure due to NamedTemporaryFilePool#6417c-bata merged 3 commits intooptuna:masterfrom
NamedTemporaryFilePool#6417c-bata merged 3 commits intooptuna:masterfrom
Conversation
2a2700d to
0450c8e
Compare
Member
|
@c-bata Could you review this PR? |
NamedTemporaryFilePool
not522
approved these changes
Jan 23, 2026
Member
not522
left a comment
There was a problem hiding this comment.
LGTM! I left brief comments, but it's fine to merge without addressing them.
|
|
||
| def tempfile(self) -> IO[bytes] | IO[str]: | ||
| f = cast("IO[bytes] | IO[str]", tempfile.NamedTemporaryFile(delete=False, **self.kwargs)) | ||
| self._file = f |
Member
There was a problem hiding this comment.
This is unrelated to this PR, but it might be good to assert that self._file is either None or a closed file here.
Co-authored-by: Naoto Mizuno <naotomizuno@preferred.jp>
Co-authored-by: Naoto Mizuno <naotomizuno@preferred.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes, Windows-test failed due to a
Permission Error(https://github.com/optuna/optuna/actions/runs/20156155033/job/57859104062?pr=6369).This PR fixes this issue to make
NamedTemporaryFilePoolthread-safe.Description of the changes