Skip to content

Remove asv and the speed benchmark workflow#6393

Merged
y0z merged 4 commits intooptuna:masterfrom
c-bata:remove-speed-benchmarks
Dec 25, 2025
Merged

Remove asv and the speed benchmark workflow#6393
y0z merged 4 commits intooptuna:masterfrom
c-bata:remove-speed-benchmarks

Conversation

@c-bata
Copy link
Copy Markdown
Member

@c-bata c-bata commented Dec 19, 2025

Motivation

The speed-benchmarks.yml workflow has not been regularly monitored by Optuna maintainers for some time. After discussion among maintainers, we decided to remove both the workflow file and the asv related files to reduce their maintenance cost.

Description of the changes

This PR removes speed-benchmarks.yml and asv related files.

@not522 not522 assigned not522 and y0z Dec 24, 2025
@not522
Copy link
Copy Markdown
Member

not522 commented Dec 24, 2025

@y0z Could you review this PR?

@not522
Copy link
Copy Markdown
Member

not522 commented Dec 24, 2025

Could you also remove benchmarks/__init__.py and these benchmark/benchmarks?

known-first-party = ["optuna", "tests", "docs", "benchmarks"]
pip install ${PIP_OPTIONS} -e '.[benchmark, checking, document, optional, test]' --extra-index-url https://download.pytorch.org/whl/cpu; \

@c-bata
Copy link
Copy Markdown
Member Author

c-bata commented Dec 24, 2025

Thank you for pointing it out 🙇 I updated two files you pointed it out and checks-optional.yaml file.

@not522
Copy link
Copy Markdown
Member

not522 commented Dec 24, 2025

Let's completely remove the benchmarks directory as well.

@c-bata
Copy link
Copy Markdown
Member Author

c-bata commented Dec 24, 2025

Addressed in a7dbfb6 🙇 🙇 🙇

@c-bata c-bata added the other Issue/PR that does not fit into any other label. label Dec 24, 2025
Copy link
Copy Markdown
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@not522 not522 removed their assignment Dec 24, 2025
Copy link
Copy Markdown
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0z y0z added this to the v4.7.0 milestone Dec 25, 2025
@y0z y0z merged commit b3bb62c into optuna:master Dec 25, 2025
21 checks passed
@c-bata c-bata deleted the remove-speed-benchmarks branch December 25, 2025 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

other Issue/PR that does not fit into any other label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants