Add warnings when JournalStorage lock acquisition is delayed#6361
Merged
not522 merged 5 commits intooptuna:masterfrom Dec 12, 2025
Merged
Add warnings when JournalStorage lock acquisition is delayed#6361not522 merged 5 commits intooptuna:masterfrom
JournalStorage lock acquisition is delayed#6361not522 merged 5 commits intooptuna:masterfrom
Conversation
Member
not522
reviewed
Dec 1, 2025
optuna/storages/journal/_file.py
Outdated
Comment on lines
+183
to
+188
| if time.monotonic() - last_warning_time > warning_interval: | ||
| optuna_warn( | ||
| f"It is taking longer than {warning_interval} seconds to acquire " | ||
| f"the lock file: {self._lock_file} Retrying..." | ||
| ) | ||
| last_warning_time = time.monotonic() |
Member
There was a problem hiding this comment.
How about issuing a warning even when self.grace_period is None?
Suggested change
| if time.monotonic() - last_warning_time > warning_interval: | |
| optuna_warn( | |
| f"It is taking longer than {warning_interval} seconds to acquire " | |
| f"the lock file: {self._lock_file} Retrying..." | |
| ) | |
| last_warning_time = time.monotonic() | |
| if time.monotonic() - last_warning_time > warning_interval: | |
| optuna_warn( | |
| f"It is taking longer than {warning_interval} seconds to acquire " | |
| f"the lock file: {self._lock_file} Retrying..." | |
| ) | |
| last_warning_time = time.monotonic() |
Collaborator
Author
|
Thank you for the suggestion. I've updated the code accordingly. PTAL! |
Member
|
How about issuing a warning right after |
Collaborator
Author
|
Thank you for the suggestion. I’ve applied this change! |
JournalStorage lock acquisition is delayed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
JournalStorage#5971.Description of the changes
JournalFileSymlinkLockandJournalFileOpenLockthat is emitted when acquiring the file lock takes longer than a certain threshold.Note
warning_intervalis tentatively set to 10 seconds, and this value is open for discussion.