Merged
Conversation
Collaborator
Author
|
@y0z (cc: @nabenabe0928 ) Could you review this PR? |
nabenabe0928
approved these changes
Dec 3, 2025
Contributor
nabenabe0928
left a comment
There was a problem hiding this comment.
@kAIto47802
Did not notice this, thank you for the catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, squaring for$\gamma' / \gamma$ is missing, which is present in the original paper.
Note
This does not affect the resulting values, since the importances are normalized in the
get_param_importancesfunction.Description of the changes
** 2