Skip to content

Replace .format with f-string in _param_importances.py#6345

Merged
c-bata merged 5 commits intooptuna:masterfrom
Harshadev-24:fix-format-in-param_importances
Nov 19, 2025
Merged

Replace .format with f-string in _param_importances.py#6345
c-bata merged 5 commits intooptuna:masterfrom
Harshadev-24:fix-format-in-param_importances

Conversation

@Harshadev-24
Copy link
Copy Markdown
Contributor

Motivation

Improved code readability and modernized string formatting using f-strings instead of .format method.

Description of changes

Replaced .format with f-string in _param_importances.py.

@Harshadev-24
Copy link
Copy Markdown
Contributor Author

The Sphinx doctest and documentation checks are failing due to intersphinx inventory network errors (HTTP 500 from external documentation sites like numpy.org, pandas.org, matplotlib.org). These are infrastructure issues unrelated to my code changes. The actual code formatting (Black/flake8) passes successfully.

@not522 not522 changed the title Replace .format with f-string in optuna/visualization/_param_importances.py Replace .format with f-string in _param_importances.py Nov 19, 2025
Copy link
Copy Markdown
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@c-bata c-bata added the code-fix Change that does not change the behavior, such as code refactoring. label Nov 19, 2025
@c-bata
Copy link
Copy Markdown
Member

c-bata commented Nov 19, 2025

@kAIto47802 Could you review this PR?

Copy link
Copy Markdown
Collaborator

@kAIto47802 kAIto47802 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. LGTM

@c-bata c-bata added this to the v4.7.0 milestone Nov 19, 2025
@c-bata c-bata merged commit bd54d86 into optuna:master Nov 19, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-fix Change that does not change the behavior, such as code refactoring.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants