Replace .format with f-strings in optuna/importance/_base#6342
Merged
sawa3030 merged 3 commits intooptuna:masterfrom Nov 19, 2025
Merged
Replace .format with f-strings in optuna/importance/_base#6342sawa3030 merged 3 commits intooptuna:masterfrom
.format with f-strings in optuna/importance/_base#6342sawa3030 merged 3 commits intooptuna:masterfrom
Conversation
Member
|
@sawa3030 Could you review this PR? |
Member
|
@VihaanMotwani Thank you for your pull request. Sorry for the extra work, but due to the recent update in the branch protection rule after #6339, could you please merge the latest master branch into yours? 🙏 |
Contributor
Author
|
hey! I merged the latest master into this branch. Github seems to be facing issues right now which might explain why CI failed: https://www.githubstatus.com/. I will try running them again once things are fixed. |
sawa3030
approved these changes
Nov 19, 2025
Collaborator
sawa3030
left a comment
There was a problem hiding this comment.
Thank you for your contribution. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request addresses part of #6305 by replacing usages of
.format(...)with f-strings.The goal is to improve readability and maintain consistency with modern Python practices.
Description of the changes
.format()calls inoptuna/importance/_base.pywith f-strings.