Merged
Conversation
not522
reviewed
Nov 12, 2025
Member
not522
left a comment
There was a problem hiding this comment.
Thank you for your PR!
Triple double quotes include indexing whitespace into the string, so please use regular strings instead.
Co-authored-by: Naoto Mizuno <naotomizuno@preferred.jp>
Co-authored-by: Naoto Mizuno <naotomizuno@preferred.jp>
Co-authored-by: Naoto Mizuno <naotomizuno@preferred.jp>
Co-authored-by: Naoto Mizuno <naotomizuno@preferred.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses Issue #6305 by refactoring string formatting in optuna/storages/_rdb/storage.py.
Description of the changes
This PR implements the following changes in optuna/storages/_rdb/storage.py: Replaced all instances of the .format(...) method with modern f-strings. Utilized the {variable!r} and {variable!s} conversion flags for exception objects (e) in logging messages to maintain the behavior of repr(e) and str(e). Utilized the {variable=} syntax where appropriate for cleaner variable name/value logging in messages.