Replace .format() with f-string in progress_bar.py#6328
Merged
c-bata merged 1 commit intooptuna:masterfrom Nov 5, 2025
Merged
Conversation
Addresses optuna#6305 by modernizing string formatting in progress_bar.py to use f-strings instead of .format() method.
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes string formatting in the progress bar module by replacing an older .format() method call with an f-string, which is the more idiomatic and readable approach in modern Python.
- Converted
.format()string formatting to f-string syntax for elapsed time display
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kAIto47802
approved these changes
Nov 5, 2025
Collaborator
kAIto47802
left a comment
There was a problem hiding this comment.
Thank you for the PR. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modernizes string formatting in
progress_bar.pyby replacing the.format()method with f-strings, as suggested in #6305.Changes
progress_bar.pyline 105-106 to use f-string syntax"{:.02f}/{} seconds".format(elapsed_seconds, self._timeout)tof"{elapsed_seconds:.02f}/{self._timeout} seconds"Related Issue
Closes #6305
Checklist