Merged
Conversation
Contributor
nabenabe0928
left a comment
There was a problem hiding this comment.
We can remove from typing_extensions import Protocol in optuna/artifacts/_protocol.py since Python 3.8 (we simply forgot removing it).
Contributor
There was a problem hiding this comment.
This config file should be scrutinized in a follow-up PR.
This was referenced Oct 14, 2025
Contributor
|
@c-bata |
c-bata
approved these changes
Oct 15, 2025
Member
c-bata
left a comment
There was a problem hiding this comment.
Changes look perfect to me. LGTM.
c-bata
requested changes
Oct 15, 2025
Member
c-bata
left a comment
There was a problem hiding this comment.
I've just noticed that the tests(3.9) and tests-rdbstorage(3.9) workflows are not triggered when a pull request is opened. Could you take a look and address them?
c-bata
approved these changes
Oct 15, 2025
Member
c-bata
left a comment
There was a problem hiding this comment.
LGTM after CI passes. Thank you for the update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Python 3.8 has been EOL for a long time, and the number of users is dwindling. Optuna will no longer support Python 3.8.
Description of the changes