Migrate .coveragerc to pyproject.toml#6292
Conversation
y0z
left a comment
There was a problem hiding this comment.
I think .coveragerc is no longer needed. So, please remove it.
https://coverage.readthedocs.io/en/latest/config.html
If .coveragerc doesn’t exist and another file hasn’t been specified, then coverage.py will look for settings in other common configuration files, in this order: setup.cfg, tox.ini, or pyproject.toml. The first file found with coverage.py settings will be used and other files won’t be consulted.
|
Hi @ParagEkbote, thank you for your pull request. Since this change is based on #6221, which was originally contributed by @vitorbborges, we’d like to make sure their contribution is properly acknowledged. Could you please rebase your branch and add a |
|
This page will be helpful: Creating a commit with multiple authors. |
|
By the way, we are currently considering dropping the use of Codecov, so your changes may be removed in the future. Still, we’d like to merge this PR to acknowledge your contribution. Thank you for your understanding. |
e5d8641 to
b8f57d5
Compare
|
I have added the co-authored commit msg, could you please review? cc: @c-bata |
|
@ParagEkbote Thank you for your update. Unfortunately, co-authoring seems to fail. If you succeeded in co-authoring, it appears that multiple icons and people are involved, as shown in the example below. Could you please fix your commit to apply co-authoring correctly? |
3a2305a to
124ef15
Compare
|
I have amended the commit and the user is now visible. Could you please review? cc: @y0z |
There was a problem hiding this comment.
The Co-authored-by footer is added only to an empty commit 124ef15, but not to the commits that actually contain the essential changes. As a result, vitorbborges’s contribution is not properly recorded in the commit history.
Could you please rebase your branch to add appropriate Co-authored-by footers to the all relevant commits, and (if possible) squash the commits? After that, please force-push the updated branch.
Co-authored-by: vitorbborges <vitorbborges@terra.com.br>
Co-authored-by: vitorbborges <vitorbborges@terra.com.br>
Co-authored-by: Yoshihiko Ozaki <30489874+y0z@users.noreply.github.com> Co-authored-by: vitorbborges <vitorbborges@terra.com.br>
Co-authored-by: vitorbborges <vitorbborges@terra.com.br>
Co-authored-by: vitorbborges <vitorbborges@terra.com.br>
Co-authored-by: vitorbborges <vitorbborges@terra.com.br>
Co-authored-by: Yoshihiko Ozaki <30489874+y0z@users.noreply.github.com> Co-authored-by: vitorbborges <vitorbborges@terra.com.br>
124ef15 to
4ede339
Compare
|
@c-bata Could you please review? |
c-bata
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the update!
Fixes #6173
As per #6221, I've only migrated .coveragerc file to pyproject.toml and not modified any other config files. Could you please review the changes?
Motivation
Have less config files to manage.
Description of the changes
Migrate
.coveragerctopyproject.toml