Fix the table of samplers in the docs#6290
Conversation
|
@sawa3030, could you review this PR? |
|
I’m aware that the text for AutoSampler is showing up in red. If you want to update it, could you please suggest a concrete solution? cf. In the original state, it had no link at all and wasn’t even shown as inline code. |
|
I also made the following two update:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6290 +/- ##
==========================================
- Coverage 89.15% 89.10% -0.05%
==========================================
Files 209 209
Lines 13908 13919 +11
==========================================
+ Hits 12399 12402 +3
- Misses 1509 1517 +8 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Yoshihiko Ozaki <30489874+y0z@users.noreply.github.com>
sawa3030
left a comment
There was a problem hiding this comment.
Thank you very much for the inofrmation and the updates. LGTM

Motivation
This PR is a follow-up PR for this PR:
Description of the changes
AutoSamplerand format it as a code block.BoTorchSampler, since it is located inoptuna_integration, not inoptuna.To add a link to the
BoTorchSamplerdocument inoptuna_integration, I addoptuna_integrationinintersphinx_mappinginconf.py. Note that this approach cannot be used forAutoSampler, since its document is not based on sphinx.Footnotes
https://www.chicagomanualofstyle.org/qanda/data/faq/topics/HyphensEnDashesEmDashes/faq0108.html ↩