Fix log PDF of discrete trunc log-norm distribution for TPESampler#6258
Fix log PDF of discrete trunc log-norm distribution for TPESampler#6258y0z merged 5 commits intooptuna:masterfrom
TPESampler#6258Conversation
|
After examining the behavior of |
|
This pull request has not seen any recent activity. |
|
This pull request has not seen any recent activity. |
|
This pull request has not seen any recent activity. |
|
This pull request has not seen any recent activity. |
|
This pull request has not seen any recent activity. |
|
This pull request has not seen any recent activity. |
| lows_cont = [] | ||
| highs_cont = [] |
There was a problem hiding this comment.
| lows_cont = [] | |
| highs_cont = [] | |
| lows_num, highs_num = [], [] |
How about renaming it to "num", since naming "cont" for both continuous and discrete distributions is a bit misleading.
There was a problem hiding this comment.
How about numeric? (num might be confusing with number)
There was a problem hiding this comment.
Thank you for your response.
That's right. numeric seems to be better.
| lows_cont = [] | |
| highs_cont = [] | |
| lows_number, highs_number = [], [] |
There was a problem hiding this comment.
Thank you. I've updated it.
kAIto47802
left a comment
There was a problem hiding this comment.
Thank you for the update! LGTM
|
This pull request has not seen any recent activity. |
|
@y0z Could you review this PR? |


Motivation
TPESamplerexhibits inconsistent handling ofsuggest_int(..., log=True). While the Parzen estimator uses the log-normal distribution's interval during sampling, it employs the log-normal distribution's value at the sampled point for the log PDF. This PR fixes the behavior to use the log-normal distribution's interval for the log PDF as well.Description of the changes
_BatchedTruncLogNormDistributionsand_BatchedDiscreteTruncLogNormDistributionsto clarify the behavior of each distribution. It is a refactoring and does not change the behavior._BatchedDiscreteTruncLogNormDistributions.Using the code below, I confirmed that the optimization performance remained nearly unchanged.