Skip to content

Speed up EHVI by optimizing tensor operation order#6257

Merged
nabenabe0928 merged 5 commits intooptuna:masterfrom
nabenabe0928:enhance/speed-up-ehvi
Sep 3, 2025
Merged

Speed up EHVI by optimizing tensor operation order#6257
nabenabe0928 merged 5 commits intooptuna:masterfrom
nabenabe0928:enhance/speed-up-ehvi

Conversation

@nabenabe0928
Copy link
Copy Markdown
Contributor

Motivation

This PR enhances the constant factor of EHVI.
By this PR, the operation on (B, S, N, K, D) will be reduced.

Description of the changes

  • Change the order of the torch tensor operations

@nabenabe0928 nabenabe0928 marked this pull request as ready for review August 21, 2025 02:46
@nabenabe0928 nabenabe0928 added the enhancement Change that does not break compatibility and not affect public interfaces, but improves performance. label Aug 21, 2025
@c-bata
Copy link
Copy Markdown
Member

c-bata commented Aug 25, 2025

@gen740 @not522 Could you review this PR?

Co-authored-by: Naoto Mizuno <naotomizuno@preferred.jp>
Copy link
Copy Markdown
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@not522 not522 removed their assignment Sep 3, 2025
@nabenabe0928 nabenabe0928 assigned kAIto47802 and unassigned gen740 Sep 3, 2025
@nabenabe0928
Copy link
Copy Markdown
Contributor Author

@kAIto47802 Could you review this PR?

@nabenabe0928 nabenabe0928 added this to the v4.6.0 milestone Sep 3, 2025
Copy link
Copy Markdown
Collaborator

@kAIto47802 kAIto47802 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabenabe0928 nabenabe0928 merged commit 18be2ad into optuna:master Sep 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Change that does not break compatibility and not affect public interfaces, but improves performance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants