Skip trial validation on copy_study#6249
Merged
c-bata merged 1 commit intooptuna:masterfrom Aug 20, 2025
Merged
Conversation
Member
|
@c-bata Could you review this PR? |
c-bata
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #6163.
As mentioned in #6163,
copy_studydoes not allowenqueued_trials whose parameters are out of the distribution range. This is becausecopy_studyinternally callstrial._validateon every trial.In
copy_study, we can assume that the trials in the study are valid (unless the user has modified the database or storage directly). Therefore, I believe that simply skipping the validation is the best solution.Description of the changes
copy_studyto skip trial validation.