Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6246 +/- ##
==========================================
+ Coverage 89.18% 89.24% +0.05%
==========================================
Files 208 208
Lines 13818 13816 -2
==========================================
+ Hits 12324 12330 +6
+ Misses 1494 1486 -8 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@c-bata |
c-bata
reviewed
Aug 14, 2025
Member
c-bata
left a comment
There was a problem hiding this comment.
Thank you for your pull request. I left one suggestion.
pyproject.toml
Outdated
| "pandas", | ||
| "pillow", | ||
| "plotly>=4.9.0", # optuna/visualization. | ||
| "plotly>=4.9.0,<6.3.0", # optuna/visualization. TODO(nabe): <6.3.0 is a hotfix, so please remove it once the bug is fixed. |
Member
There was a problem hiding this comment.
Could you specify the upper version constraint on windows-tests.yml? I think this constraint should not be affected to all platforms.
optuna/.github/workflows/windows-tests.yml
Lines 55 to 58 in e6b2e42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes