Speed up log pdf in _BatchedTruncNormDistributions by vectorization#6220
Merged
y0z merged 2 commits intooptuna:masterfrom Aug 1, 2025
Merged
Speed up log pdf in _BatchedTruncNormDistributions by vectorization#6220y0z merged 2 commits intooptuna:masterfrom
_BatchedTruncNormDistributions by vectorization#6220y0z merged 2 commits intooptuna:masterfrom
Conversation
Member
not522
approved these changes
Jul 31, 2025
Comment on lines
-132
to
-133
| x_lower = np.maximum(xi_uniq - d.step / 2, lower_limit)[:, np.newaxis] | ||
| x_upper = np.minimum(xi_uniq + d.step / 2, upper_limit)[:, np.newaxis] |
Member
There was a problem hiding this comment.
Note: Since x is a sampled value, it is within the range of lower_limit and upper_limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The vectorization for continuous distributions can speed up for
multivariate=True.Description of the changes