Delete test_get_timeline_plot_with_killed_running_trials#6210
Merged
c-bata merged 2 commits intooptuna:masterfrom Jul 23, 2025
Merged
Delete test_get_timeline_plot_with_killed_running_trials#6210c-bata merged 2 commits intooptuna:masterfrom
test_get_timeline_plot_with_killed_running_trials#6210c-bata merged 2 commits intooptuna:masterfrom
Conversation
…t_with_killed_running_trials
nabenabe0928
approved these changes
Jul 22, 2025
Contributor
nabenabe0928
left a comment
There was a problem hiding this comment.
Thank you for the PR, LGTM!
test_get_timeline_plot_with_killed_running_trials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Related to #6206.
test_get_timeline_plot_with_killed_running_trialshas become brittle since we introducedpytest-xdist. Under heavy CI load, execution is considerably slower, and the test now fails occasionally.In addition, the test couples tightly to Plotly’s internal structure:
Because these internals may change with any Plotly update, the test is easily broken.
Given the maintenance cost and limited benefit, I believe we should remove it.
Description of the changes