Skip to content

Fix test_log_completed_trial_skip_storage_access#6208

Merged
nabenabe0928 merged 1 commit intooptuna:masterfrom
not522:fix-test_log_completed_trial_skip_storage_access
Jul 18, 2025
Merged

Fix test_log_completed_trial_skip_storage_access#6208
nabenabe0928 merged 1 commit intooptuna:masterfrom
not522:fix-test_log_completed_trial_skip_storage_access

Conversation

@not522
Copy link
Copy Markdown
Member

@not522 not522 commented Jul 18, 2025

Motivation

Fix the first problem on #6206. test_log_completed_trial_skip_storage_access is incorrectly dependent on previously executed tests.

Description of the changes

Reset the logger and set the logging level.

@not522 not522 added the test Unit test. label Jul 18, 2025
@nabenabe0928 nabenabe0928 added this to the v4.5.0 milestone Jul 18, 2025
@nabenabe0928
Copy link
Copy Markdown
Contributor

@y0z Could you review this PR?

Copy link
Copy Markdown
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0z y0z removed their assignment Jul 18, 2025
Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabenabe0928 nabenabe0928 merged commit 0b06c15 into optuna:master Jul 18, 2025
15 checks passed
@not522 not522 deleted the fix-test_log_completed_trial_skip_storage_access branch July 18, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Unit test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants