Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6201 +/- ##
==========================================
- Coverage 88.30% 88.29% -0.01%
==========================================
Files 207 207
Lines 14091 14085 -6
==========================================
- Hits 12443 12437 -6
Misses 1648 1648 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@y0z @fusawa-yugo @sawa3030 |
Collaborator
|
The change looks reasonable to me. However, I couldn't observe the performance improvement in my environment based on benchmarking of
Benchmarking CodeI used the code in PR #6200 as a reference. |
_truncnorm implementation_truncnorm
Contributor
Author
|
@sawa3030 I renamed the PR title! |
sawa3030
approved these changes
Jul 22, 2025
Collaborator
sawa3030
left a comment
There was a problem hiding this comment.
Thank you for the explanation. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
This PR is to speed up
TPESampler.Description of the changes
:=to avoid duplicated filtering_log_gauss_massnp.selectto reduce the constant factor in the filtering process