Merged
Conversation
Contributor
|
This pull request has not seen any recent activity. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6198 +/- ##
==========================================
- Coverage 88.38% 88.12% -0.26%
==========================================
Files 207 207
Lines 14030 14051 +21
==========================================
- Hits 12400 12383 -17
- Misses 1630 1668 +38 ☔ View full report in Codecov by Sentry. |
Contributor
|
This PR looks almost good to me:) |
Collaborator
|
This PR looks almost good to me. I’ll take another look once the part pointed out by @nabenabe0928 is addressed. |
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
For multi‑objective constrained GP sampling,
ConstrainedLogEHVIis needed.Description of the changes
ConstrainedLogEHVI.