Merged
Conversation
Contributor
Author
|
@sawa3030 @kAIto47802 |
kAIto47802
approved these changes
Jun 27, 2025
Collaborator
kAIto47802
left a comment
There was a problem hiding this comment.
Thank you for the PR. LGTM!
GPSampler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The original implementation takes
best_paramsas thexfetched byargmax(Y[is_feasible]).However, what we really want is
xwith the best feasibley.See the example below,
In this case,
feasible = [False, True, True], meaning thatY_feasible = [3.0, 5.0]andX_feasible = [[4.0], [2.0]].So
X[argmax(Y_feasible)]becomes[4.0]instead of[2.0], which is the actual best feasible params.I fixed this bug in this PR.
Note
Here, we aim to maximize
Y.Description of the changes