Skip to content

Remove optuna-fast-fanova references from documentation#6178

Merged
gen740 merged 1 commit intooptuna:masterfrom
c-bata:remove-optuna-fast-fanova
Jul 1, 2025
Merged

Remove optuna-fast-fanova references from documentation#6178
gen740 merged 1 commit intooptuna:masterfrom
c-bata:remove-optuna-fast-fanova

Conversation

@c-bata
Copy link
Copy Markdown
Member

@c-bata c-bata commented Jun 25, 2025

Motivation

https://github.com/optuna/optuna-fast-fanova is not maintained.

Description of the changes

Remove references to optuna-fast-fanova from the documentation.

@c-bata c-bata added the document Documentation related. label Jun 25, 2025
@nabenabe0928 nabenabe0928 requested a review from Copilot June 26, 2025 04:52
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes outdated references to the unmaintained optuna-fast-fanova library from both code docstrings and documentation pages.

  • Eliminates notes promoting optuna-fast-fanova in the visualization API docstring.
  • Clears mentions of the external Cython-accelerated fANOVA implementation in the importance evaluator code.
  • Strips out guidance on optuna-fast-fanova from the core importance module and RST reference.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
optuna/visualization/_param_importances.py Removed note about optuna-fast-fanova speed
optuna/importance/_fanova/_evaluator.py Deleted outdated optuna-fast-fanova note
optuna/importance/init.py Cleared external fANOVA library reference
docs/source/reference/importance.rst Stripped optuna-fast-fanova documentation

@nabenabe0928
Copy link
Copy Markdown
Contributor

@sawa3030 @gen740
Could you review this PR?

Copy link
Copy Markdown
Collaborator

@sawa3030 sawa3030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@gen740 gen740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gen740 gen740 added this to the v4.5.0 milestone Jul 1, 2025
@gen740 gen740 merged commit 01ffdd1 into optuna:master Jul 1, 2025
17 checks passed
@c-bata c-bata deleted the remove-optuna-fast-fanova branch July 2, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

document Documentation related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants