Print fully qualified name of experimental function by default#6162
Merged
nabenabe0928 merged 3 commits intooptuna:masterfrom Jun 18, 2025
Merged
Print fully qualified name of experimental function by default#6162nabenabe0928 merged 3 commits intooptuna:masterfrom
nabenabe0928 merged 3 commits intooptuna:masterfrom
Conversation
Contributor
|
Thank you, @ktns , for this PR! |
HideakiImamura
approved these changes
Jun 18, 2025
Member
HideakiImamura
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks very good.
Contributor
|
I tried the code below: import optuna
study = optuna.create_study()
study.set_metric_names(["a"])and obtained the following log: |
nabenabe0928
approved these changes
Jun 18, 2025
Contributor
nabenabe0928
left a comment
There was a problem hiding this comment.
Thank you for the PR, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, warning messages from experimental functions decorated by
optuna._experimental.experimental_funcseems only include their function name and not include which module they are defined in.Description of the changes
This PR change the decorator so that the warning messages include module name and include
__qualname__instead of__name__.