Skip to content

Refactor return style #6136#6151

Merged
nabenabe0928 merged 1 commit intooptuna:masterfrom
unKnownNG:refactor-return-v3.0.0.c.py
Jun 13, 2025
Merged

Refactor return style #6136#6151
nabenabe0928 merged 1 commit intooptuna:masterfrom
unKnownNG:refactor-return-v3.0.0.c.py

Conversation

@unKnownNG
Copy link
Copy Markdown
Contributor

Description:

This PR updates the return statement style in optuna/storages/_rdb/alembic/versions/v3.0.0.c.py to follow Optuna’s convention of using tuple unpacking without parentheses, i.e., return a, b instead of return (a, b).

Motivation:

According to the project’s code style and consistency guidelines (referenced in issue #6136), Optuna prefers return a, b over return (a, b) when returning multiple values. This change aligns the file with that convention and improves consistency across the codebase.

Note:

The changes made in the file did not change any logic of the code.

@unKnownNG unKnownNG changed the title Racator return style #6136 Rafator return style #6136 Jun 12, 2025
@unKnownNG unKnownNG changed the title Rafator return style #6136 Refactor return style #6136 Jun 12, 2025
Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@nabenabe0928 nabenabe0928 added the code-fix Change that does not change the behavior, such as code refactoring. label Jun 13, 2025
@nabenabe0928 nabenabe0928 added this to the v4.5.0 milestone Jun 13, 2025
@nabenabe0928 nabenabe0928 merged commit f815ef3 into optuna:master Jun 13, 2025
15 checks passed
@unKnownNG unKnownNG deleted the refactor-return-v3.0.0.c.py branch June 13, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-fix Change that does not change the behavior, such as code refactoring.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants