Skip to content

Simplify tuple return in test_trial.py#6141

Merged
nabenabe0928 merged 2 commits intooptuna:masterfrom
saishreyakumar:fix-return-tuple-test-trial
Jun 9, 2025
Merged

Simplify tuple return in test_trial.py#6141
nabenabe0928 merged 2 commits intooptuna:masterfrom
saishreyakumar:fix-return-tuple-test-trial

Conversation

@saishreyakumar
Copy link
Copy Markdown
Contributor

@saishreyakumar saishreyakumar commented Jun 8, 2025

Motivation

This PR addresses #6136 it simplifies the tuple return in tests/trial_tests/test_trial.py to align with the existing Optuna code style, which prefers returning tuples without parentheses when possible, improving code consistency.

Description of the changes

Removed parentheses in tuple return statements in test_trial.py.

Tested function that was changed:
image

Notes

This PR only modifies the return syntax in test_trial.py.

@nabenabe0928 nabenabe0928 added the code-fix Change that does not change the behavior, such as code refactoring. label Jun 8, 2025
@nabenabe0928
Copy link
Copy Markdown
Contributor

Thank you for the PR:)
Could you merge the master branch?
It should fix the checks.

@nabenabe0928 nabenabe0928 changed the title style: simplify tuple return in test_trial.py Simplify tuple return in test_trial.py Jun 9, 2025
Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabenabe0928 nabenabe0928 enabled auto-merge June 9, 2025 04:01
@nabenabe0928 nabenabe0928 added this to the v4.4.0 milestone Jun 9, 2025
@nabenabe0928 nabenabe0928 merged commit b0f1482 into optuna:master Jun 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-fix Change that does not change the behavior, such as code refactoring.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants