Skip to content

Refactor return standardization in optim_mixed.py#6140

Merged
nabenabe0928 merged 4 commits intooptuna:masterfrom
Ajay-Satish-01:return_standardization
Jun 9, 2025
Merged

Refactor return standardization in optim_mixed.py#6140
nabenabe0928 merged 4 commits intooptuna:masterfrom
Ajay-Satish-01:return_standardization

Conversation

@Ajay-Satish-01
Copy link
Copy Markdown
Contributor

@Ajay-Satish-01 Ajay-Satish-01 commented Jun 8, 2025

Motivation

To standardize the return format of function in the file optuna/_gp/optim_mixed.py.
PR related to issue #6136 #6142

Description of the changes

  • Used the format return a, b
  • Fixed a type error

NOTE

@nabenabe0928 nabenabe0928 added the code-fix Change that does not change the behavior, such as code refactoring. label Jun 8, 2025
Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you merge the master branch?
I manually fixed the conflict, so please don't forget fetching your remote repository first!

@Ajay-Satish-01
Copy link
Copy Markdown
Contributor Author

Could you merge the master branch? I manually fixed the conflict, so please don't forget fetching your remote repository first!

Sure. Do you want me to do anything after merging my master branch?

@nabenabe0928
Copy link
Copy Markdown
Contributor

@Ajay-Satish-01
Thank you for the swift action:)
All we need is to wait for the CI to pass!

@Ajay-Satish-01
Copy link
Copy Markdown
Contributor Author

@Ajay-Satish-01 Thank you for the swift action:) All we need is to wait for the CI to pass!

No issues. Thanks :)

Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabenabe0928 nabenabe0928 enabled auto-merge June 9, 2025 02:03
@nabenabe0928 nabenabe0928 added this to the v4.4.0 milestone Jun 9, 2025
@nabenabe0928 nabenabe0928 changed the title refactor: return standardization, fixed type error Refactor return standardization in optim_mixed.py Jun 9, 2025
@nabenabe0928 nabenabe0928 merged commit c1f8617 into optuna:master Jun 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-fix Change that does not change the behavior, such as code refactoring.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incompatible types when running mypy hook

2 participants