Cache split infromation for TPESampler#6128
Cache split infromation for TPESampler#6128fusawa-yugo wants to merge 2 commits intooptuna:masterfrom
TPESampler#6128Conversation
|
I have a question. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6128 +/- ##
==========================================
+ Coverage 88.39% 88.43% +0.04%
==========================================
Files 207 207
Lines 14036 14051 +15
==========================================
+ Hits 12407 12426 +19
+ Misses 1629 1625 -4 ☔ View full report in Codecov by Sentry. |
|
This pull request has not seen any recent activity. |
TPESampler
|
This pull request has not seen any recent activity. |
|
I noticed a concern, so let me leave a note here: In principle, this PR should speed up TPESampler in many cases, but it could also have a negative impact. |
|
This pull request has not seen any recent activity. |
|
This pull request has not seen any recent activity. |
|
This pull request was closed automatically because it had not seen any recent activity. If you want to discuss it, you can reopen it freely. |
Motivation
This is a revival of #5464.
In the current implementation,
_split_cacheis unnecessarily repeated even when the results would be identical.This PR aims to eliminate such redundant computations and improve efficiency.
Description of the changes
The content is same as #5464 for now.
The cache uses
trial.numberas the key, and the value is the result of the split operation.