Merged
Conversation
Contributor
Author
|
@sawa3030 @kAIto47802 Could you check this PR? |
kAIto47802
approved these changes
Jun 6, 2025
Collaborator
kAIto47802
left a comment
There was a problem hiding this comment.
Thank you for your PR. LGTM!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6125 +/- ##
==========================================
+ Coverage 88.29% 88.30% +0.01%
==========================================
Files 207 207
Lines 14034 14025 -9
==========================================
- Hits 12391 12385 -6
+ Misses 1643 1640 -3 ☔ View full report in Codecov by Sentry. |
sawa3030
reviewed
Jun 12, 2025
Collaborator
|
Apologies for the delay. I’ve left a minor comment. PTAL |
Co-authored-by: Eri Sawada <125344906+sawa3030@users.noreply.github.com>
Contributor
Author
|
@sawa3030 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR makes the GP-related documentations cleaner.
Description of the changes