Improve parallelization document#6123
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6123 +/- ##
==========================================
+ Coverage 88.34% 88.39% +0.05%
==========================================
Files 207 207
Lines 13975 14036 +61
==========================================
+ Hits 12346 12407 +61
Misses 1629 1629 ☔ View full report in Codecov by Sentry. |
HideakiImamura
left a comment
There was a problem hiding this comment.
Thanks for the PR! Basically, LGTM. I have several comments, PTAL.
e27dac7 to
8267f90
Compare
Co-authored-by: Hideaki Imamura <38826298+HideakiImamura@users.noreply.github.com> Update tutorial/10_key_features/004_distributed.py Co-authored-by: Hideaki Imamura <38826298+HideakiImamura@users.noreply.github.com> Update tutorial/10_key_features/004_distributed.py Co-authored-by: Hideaki Imamura <38826298+HideakiImamura@users.noreply.github.com> Apply suggestions from code review Co-authored-by: Hideaki Imamura <38826298+HideakiImamura@users.noreply.github.com> Update tutorial/10_key_features/004_distributed.py Co-authored-by: Hideaki Imamura <38826298+HideakiImamura@users.noreply.github.com>
79cba7f to
2e9cff4
Compare
ec5f0fc to
a4b0861
Compare
|
@sawa3030 Could you review this PR? |
b5a882a to
a0defcb
Compare
a0defcb to
64a7b94
Compare
sawa3030
left a comment
There was a problem hiding this comment.
Apologies for the delay, and thank you for your patience. I found the document very helpful and easy to follow, even as a beginner in parallelization. I've added a few minor comments. PTAL.
Co-authored-by: Eri Sawada <125344906+sawa3030@users.noreply.github.com>
|
@sawa3030 |
|
|
||
| .. _multi-thread-optimization: | ||
|
|
||
| Multi-thread Optimization |
There was a problem hiding this comment.
The current titles seem to follow this pattern:
- Multi-thread Optimization
- Multi-process Optimization with JournalStorage
- Multi-node Optimization
- GRPC Proxy Storage
To make them more consistent, how about updating them to:
- Multi-thread Optimization
- Multi-process Optimization with JournalStorage
- Multi-node Optimization with RDBStorage
- Multi-node Optimization with GrpcStorageProxy
sawa3030
left a comment
There was a problem hiding this comment.
Thank you for the updates. LGTM
Motivation
The Easy Parallelization section of the Optuna documentation is somewhat outdated.
To improve its clarity and usefulness, I have updated the content by adding additional descriptions and illustrative diagrams.
These changes aim to better reflect current best practices for multi-threaded, multi-process, and multi-node optimization in Optuna.
Description of the changes