Skip to content

add deprecated/removed version specification to calls of convert_positional_args#6117

Merged
y0z merged 3 commits intooptuna:masterfrom
shmurai:specify-versions-convert_positional_args
Jun 4, 2025
Merged

add deprecated/removed version specification to calls of convert_positional_args#6117
y0z merged 3 commits intooptuna:masterfrom
shmurai:specify-versions-convert_positional_args

Conversation

@shmurai
Copy link
Copy Markdown
Contributor

@shmurai shmurai commented May 31, 2025

Motivation

a follow-up PR for #5485.

Description of the changes

Adds deprecated_version and removed_version to usages of @convert_positional_args.
It is also used in test_convert_positional_args.py but I deliberately kept this unchanged because it is about tesing the decorator itself.

@shmurai
Copy link
Copy Markdown
Contributor Author

shmurai commented May 31, 2025

references to related changes

_upload.py

#5533

study.py

#3270

_fixed.py

#5044

_frozen.py

#5044

_trial.py

#5044

@not522 not522 added the sprint-20250531 PR from the online sprint event May 31, 2025. label May 31, 2025
@toshihikoyanase toshihikoyanase added the code-fix Change that does not change the behavior, such as code refactoring. label May 31, 2025
@not522 not522 added enhancement Change that does not break compatibility and not affect public interfaces, but improves performance. and removed code-fix Change that does not change the behavior, such as code refactoring. labels May 31, 2025
@shmurai
Copy link
Copy Markdown
Contributor Author

shmurai commented May 31, 2025

Now all usages of @convert_positional_args are annotated with versions, so I made version arguments required

@y0z y0z self-assigned this May 31, 2025
not522
not522 approved these changes May 31, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

y0z
y0z approved these changes Jun 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0z y0z merged commit 6e8d65c into optuna:master Jun 4, 2025
14 checks passed
@y0z y0z added this to the v4.4.0 milestone Jun 4, 2025
@y0z y0z removed their assignment Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@not522 not522 not522 approved these changes

@y0z y0z y0z approved these changes

Assignees

No one assigned

Labels

enhancement Change that does not break compatibility and not affect public interfaces, but improves performance. sprint-20250531 PR from the online sprint event May 31, 2025.

Projects

None yet

Milestone

v4.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@shmurai @not522 @y0z @toshihikoyanase