Emit ExperimentalWarning if heartbeat is enabled#6106
Merged
contramundum53 merged 2 commits intooptuna:masterfrom May 31, 2025
Merged
Emit ExperimentalWarning if heartbeat is enabled#6106contramundum53 merged 2 commits intooptuna:masterfrom
ExperimentalWarning if heartbeat is enabled#6106contramundum53 merged 2 commits intooptuna:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6106 +/- ##
==========================================
- Coverage 88.35% 88.25% -0.10%
==========================================
Files 207 207
Lines 13995 14002 +7
==========================================
- Hits 12365 12358 -7
- Misses 1630 1644 +14 ☔ View full report in Codecov by Sentry. |
Member
|
LGTM. |
contramundum53
approved these changes
May 31, 2025
Member
|
Since this PR is small, I'll merge it with one approval. |
ExperimentalWarning if heartbeat is enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When we use the heartbeat mechanism of RDBStorage, only
fail_stale_trialsemits ExperimentalWarning currently.Because the heartbeat mechanism itself is an experimental feature at this moment, it is more helpful to emit an ExperimentalWarning more holistically.
Description of the changes
This PR emits ExperimentalWarning at initializing RDBStorage with
heartbeat_interval.This PR does not address the existing ExperimentalWarning from
fail_stale_trials. Thus, we will see two distinct ExperimentalWarning if we usefail_stale_trials.