Skip to content

Refactor test_base_gasampler.py#6104

Merged
gen740 merged 1 commit intooptuna:masterfrom
sawa3030:follow-up-6066
Jun 3, 2025
Merged

Refactor test_base_gasampler.py#6104
gen740 merged 1 commit intooptuna:masterfrom
sawa3030:follow-up-6066

Conversation

@sawa3030
Copy link
Copy Markdown
Collaborator

Motivation

Follow up #6066

@sawa3030 sawa3030 changed the title Update test_base_gasampler.py Refactor test_base_gasampler.py May 30, 2025
@sawa3030
Copy link
Copy Markdown
Collaborator Author

I have confirmed that the test fails with the implementation prior to PR #6066.

@toshihikoyanase toshihikoyanase added the test Unit test. label May 31, 2025
Copy link
Copy Markdown
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0z
Copy link
Copy Markdown
Member

y0z commented Jun 3, 2025

@gen740 Could you review this PR since this is a follow-up of #6066?

Copy link
Copy Markdown
Member

@gen740 gen740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gen740 gen740 added this to the v4.4.0 milestone Jun 3, 2025
@gen740 gen740 merged commit a30812e into optuna:master Jun 3, 2025
15 checks passed
@gen740 gen740 removed their assignment Jun 3, 2025
@sawa3030 sawa3030 deleted the follow-up-6066 branch November 14, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Unit test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants