Skip to content

Support mypy 1.16.0#6102

Merged
c-bata merged 1 commit intooptuna:masterfrom
not522:mypy-1.16.0
May 30, 2025
Merged

Support mypy 1.16.0#6102
c-bata merged 1 commit intooptuna:masterfrom
not522:mypy-1.16.0

Conversation

@not522
Copy link
Copy Markdown
Member

@not522 not522 commented May 30, 2025

Motivation

mypy 1.16.0 was released and caused type checking to fail, so this is being fixed.

Checks (with optional dependencies) was passed on my fork repository. https://github.com/not522/optuna/actions/runs/15338034115/job/43158870501

Description of the changes

  • Fix type checking

Copy link
Copy Markdown
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-bata c-bata added the code-fix Change that does not change the behavior, such as code refactoring. label May 30, 2025
@c-bata c-bata added this to the v4.4.0 milestone May 30, 2025
@c-bata c-bata merged commit 7f3d9f1 into optuna:master May 30, 2025
16 checks passed
@not522 not522 deleted the mypy-1.16.0 branch May 30, 2025 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-fix Change that does not change the behavior, such as code refactoring.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants