Add AcquisitionFuncParams for LogEHVI#6052
Merged
nabenabe0928 merged 30 commits intooptuna:masterfrom May 2, 2025
Merged
Conversation
nabenabe0928
commented
Apr 25, 2025
Contributor
Author
|
@HideakiImamura @kAIto47802 |
kAIto47802
reviewed
Apr 30, 2025
kAIto47802
requested changes
Apr 30, 2025
Co-authored-by: kAIto47802 <115693559+kAIto47802@users.noreply.github.com>
kAIto47802
reviewed
Apr 30, 2025
kAIto47802
reviewed
Apr 30, 2025
kAIto47802
requested changes
Apr 30, 2025
Collaborator
kAIto47802
left a comment
There was a problem hiding this comment.
I have finished reviewing acqf.py, leaving some comments. PTAL 
Co-authored-by: kAIto47802 <115693559+kAIto47802@users.noreply.github.com>
Member
HideakiImamura
left a comment
There was a problem hiding this comment.
Thanks for the PR. I have several comments. PTAL.
Co-authored-by: Hideaki Imamura <38826298+HideakiImamura@users.noreply.github.com>
Co-authored-by: Hideaki Imamura <38826298+HideakiImamura@users.noreply.github.com>
HideakiImamura
approved these changes
May 1, 2025
Member
HideakiImamura
left a comment
There was a problem hiding this comment.
Thanks for the update! LGTM!
kAIto47802
approved these changes
May 2, 2025
Collaborator
kAIto47802
left a comment
There was a problem hiding this comment.
Thank you for the update! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds an interface for LogEHVI, a multi-objective acquisition function.
Although this PR passes the CI standalone, this PR should be merged after