Make all arguments of TPESampler keyword-only#6041
Merged
y0z merged 3 commits intooptuna:masterfrom May 7, 2025
Merged
Conversation
Member
|
@y0z @kAIto47802 Could you review this PR? |
Collaborator
Author
|
@y0z @kAIto47802 I'd appreciate it if you could take a look at this PR. Thank you in advance! |
y0z
previously approved these changes
Apr 23, 2025
not522
reviewed
Apr 25, 2025
Member
not522
left a comment
There was a problem hiding this comment.
Since the arguments after consider_prior will be shifted, isn't it necessary to make all positional arguments keyword-only?
consider_prior in TPESamplerTPESampler keyword-only
Collaborator
Author
|
I have made the updates! I have also confirmed that all usages of |
Contributor
|
This pull request has not seen any recent activity. |
kAIto47802
approved these changes
May 7, 2025
Collaborator
kAIto47802
left a comment
There was a problem hiding this comment.
Thank you for your PR! LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
consider_priorargument inTPESamplerwill be deprecated, as outlined in #6007. To prepare for this removal, all arguments of TPESampler are now defined as keyword-only.Description of the Changes
TPESamplerconstructor to make all arguments keyword-only.@convert_positional_argsdecorator.