improve time complexity of IntersectionSearchSpace #5949#5981
Closed
GittyHarsha wants to merge 1 commit intooptuna:masterfrom
Closed
improve time complexity of IntersectionSearchSpace #5949#5981GittyHarsha wants to merge 1 commit intooptuna:masterfrom
GittyHarsha wants to merge 1 commit intooptuna:masterfrom
Conversation
Contributor
Author
|
Hi @not522, would you mind reviewing this PR? |
Member
|
I think this PR change causes the test errors. Could you check if your change only improves the speed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix issue #5949
Description of the changes
Removed this line
optuna/optuna/search_space/intersection.py
Line 29 in 229fe58
and adding filtering logic inside the for-loop