Skip to content

Removed FirstTrialOnlyRandomSampler#5973

Merged
y0z merged 2 commits intooptuna:masterfrom
mehakmander11:removed-firstTrial
Feb 14, 2025
Merged

Removed FirstTrialOnlyRandomSampler#5973
y0z merged 2 commits intooptuna:masterfrom
mehakmander11:removed-firstTrial

Conversation

@mehakmander11
Copy link
Copy Markdown
Contributor

@mehakmander11 mehakmander11 commented Feb 13, 2025

This PR removes FirstTrialOnlyRandomSampler, fixes #5970

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.46%. Comparing base (0a649e3) to head (80cdc1e).
Report is 61 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5973      +/-   ##
==========================================
- Coverage   88.46%   88.46%   -0.01%     
==========================================
  Files         205      207       +2     
  Lines       13768    13823      +55     
==========================================
+ Hits        12180    12228      +48     
- Misses       1588     1595       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nzw0301 nzw0301 changed the title Fixes # 5970: removed FirstTrialOnlyRandomSampler Removed FirstTrialOnlyRandomSampler Feb 13, 2025
@nzw0301 nzw0301 added the code-fix Change that does not change the behavior, such as code refactoring. label Feb 13, 2025
Copy link
Copy Markdown
Member

@nzw0301 nzw0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you apply black?

Copy link
Copy Markdown
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0z y0z merged commit e7462ae into optuna:master Feb 14, 2025
14 checks passed
@y0z y0z added this to the v4.3.0 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-fix Change that does not change the behavior, such as code refactoring.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove FirstTrialOnlyRandomSampler in testing/samplers.py

3 participants