Ensure gRPC server readiness before proceeding to prevent test failures#5938
Merged
nabenabe0928 merged 3 commits intooptuna:masterfrom Jan 28, 2025
Merged
Ensure gRPC server readiness before proceeding to prevent test failures#5938nabenabe0928 merged 3 commits intooptuna:masterfrom
nabenabe0928 merged 3 commits intooptuna:masterfrom
Conversation
c-bata
reviewed
Jan 23, 2025
Comment on lines
+104
to
+109
| while True: | ||
| try: | ||
| proxy.get_all_studies() | ||
| break | ||
| except grpc.RpcError: | ||
| continue |
Member
There was a problem hiding this comment.
Could you add a time.sleep() to avoid a busy loop?
Suggested change
| while True: | |
| try: | |
| proxy.get_all_studies() | |
| break | |
| except grpc.RpcError: | |
| continue | |
| while True: | |
| try: | |
| proxy.get_all_studies() | |
| break | |
| except grpc.RpcError: | |
| time.sleep(1) | |
| continue |
Member
|
@nabenabe0928 Could you review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ref: Fix
StorageSupplier("grpc")to make unit tests robust. #5925The issue occurs when the proxy begins communicating with the server before the server has fully started. By ensuring the server is ready before proceeding, this change aims to make the unit tests more robust.
Description of the changes