fix(storage): Fix threading lock logic#5922
Merged
not522 merged 1 commit intooptuna:masterfrom Jan 31, 2025
Merged
Conversation
c-bata
reviewed
Jan 10, 2025
Contributor
|
This pull request has not seen any recent activity. |
Contributor
not522
reviewed
Jan 29, 2025
Member
not522
left a comment
There was a problem hiding this comment.
The change is LGTM, but I'm not confident it relates to the free-threaded Python. I confirmed that the reported error in #5862 occurs in 3.13.1 and 3.13.1t.
Is it okay to merge this PR as a ordinary bug fix?
Member
Author
Member
|
Yes, this PR fixes the error in the my both environments. So, the motivation described above is misleading?
I think this PR is not limited to the free-threaded Python. |
Member
Author
|
I see, that sounds reasonable. |
Member
|
Thanks! My question is resolved, so I merge this PR. |
not522
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As shown in #5862, journal storage sometimes fails on free-threaded Python. This is because the journal store accesses the shared data without getting the lock.
Description of the changes
Increase the lock range in the journal storage.