Match the argument order of download_artifact to that of upload_artifact#5529
Closed
nabenabe0928 wants to merge 1 commit intooptuna:masterfrom
Closed
Match the argument order of download_artifact to that of upload_artifact#5529nabenabe0928 wants to merge 1 commit intooptuna:masterfrom
download_artifact to that of upload_artifact#5529nabenabe0928 wants to merge 1 commit intooptuna:masterfrom
Conversation
Member
|
@c-bata, @porink0424 Could you review this PR? |
Member
|
Could you show us the correspondence of the arguments between |
Contributor
Author
|
@toshihikoyanase def upload_artifact(study_or_trial, file_path, artifact_store, ...) -> str:
...
def download_artifact(artifact_store, artifact_id, file_path) -> None:
...I updated def download_artifact(file_path, artifact_store, artifact_id) -> None:
...so that def upload_artifact(artifact_store, file_path, study_or_trial, ...) -> str:
...
def download_artifact(artifact_store, file_path, artifact_id) -> None:
...Although this change makes the order clearer, it will be a breaking change. |
porink0424
approved these changes
Jun 28, 2024
Member
porink0424
left a comment
There was a problem hiding this comment.
I think this change is enough, and further breaking change is a bit much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I united the argument order of
download_artifactto that ofupload_artifactto avoid confusion.