Follow up for split integrations#5277
Merged
eukaryo merged 10 commits intooptuna:masterfrom Mar 4, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5277 +/- ##
==========================================
- Coverage 89.59% 89.56% -0.04%
==========================================
Files 209 209
Lines 13103 13103
==========================================
- Hits 11740 11736 -4
- Misses 1363 1367 +4 ☔ View full report in Codecov by Sentry. |
Member
|
@eukaryo Could you review this PR? |
Collaborator
|
LGTM. |
eukaryo
approved these changes
Mar 4, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Task #4484 has been completed. However, there are some pending items in the backlog.
The file test_integration.py is ineffective. Consequently, the integration CI is meaningless.
Description of the changes
integration_test.ymlmac-tests.ymlandwindows-tests.ymltest_samplers.py.